-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Zaowang/adding 2024 06 01 preview for nginx #29773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zaowang/adding 2024 06 01 preview for nginx #29773
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| swagger.json | 2024-06-01-preview(d770711) | 2023-09-01(main) |
| swagger.json | 2024-06-01-preview(d770711) | 2024-01-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
| The '$ref' property points to different models in the old and new versions. New: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1619:15 Old: NGINX.NGINXPLUS/stable/2023-09-01/swagger.json#L1516:15 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 2 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2024-06-01-preview | package-2024-06-01-preview(d770711) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1386 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1462 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
ResourceNameRestriction |
The resource name parameter 'certificateName' should be defined with a 'pattern' restriction. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L29 |
RequestSchemaForTrackedResourcesMustHaveTags |
A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L80 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L137 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L151 |
LroLocationHeader |
A 202 response should include an Location response header. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L185 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L194 |
ResourceNameRestriction |
The resource name parameter 'configurationName' should be defined with a 'pattern' restriction. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L302 |
RequestSchemaForTrackedResourcesMustHaveTags |
A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L353 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L410 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L424 |
LroLocationHeader |
A 202 response should include an Location response header. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L458 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L467 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L639 |
PatchResponseCodes |
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L653 |
UnSupportedPatchProperties |
Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L678 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:profiles. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L681 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:upgradeChannel. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L681 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:name. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L681 |
LroPatch202 |
The async patch operation should return 202. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L686 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L702 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L713 |
LroLocationHeader |
A 202 response should include an Location response header. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L740 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L749 |
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L867 |
TrackedResourcePatchOperation |
Tracked resource 'NginxCertificate' must have patch operation that at least supports the update of tags. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1006 |
TrackedResourcePatchOperation |
Tracked resource 'NginxConfiguration' must have patch operation that at least supports the update of tags. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1102 |
| Use the latest version v5 of types.json. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L41 |
|
| Use the latest version v5 of types.json. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L44 |
|
| Use the latest version v5 of types.json. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L57 |
|
| Use the latest version v5 of types.json. Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L94 |
️❌Avocado: 104 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":1},"token":"<","message":"invalid symbol, token: <, line: 8, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":2},"token":"<","message":"invalid symbol, token: <, line: 8, column: 2","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":3},"token":"<","message":"invalid symbol, token: <, line: 8, column: 3","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":4},"token":"<","message":"invalid symbol, token: <, line: 8, column: 4","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":5},"token":"<","message":"invalid symbol, token: <, line: 8, column: 5","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":6},"token":"<","message":"invalid symbol, token: <, line: 8, column: 6","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":7},"token":"<","message":"invalid symbol, token: <, line: 8, column: 7","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid token","position":{"line":8,"column":9},"token":"HEAD","message":"invalid token, token: HEAD, line: 8, column: 9","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"structure","code":"unexpected token","position":{"line":9,"column":5},"token":""requestBody"","message":"unexpected token, token: "requestBody", line: 9, column: 5","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":1},"token":"=","message":"invalid symbol, token: =, line: 10, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":2},"token":"=","message":"invalid symbol, token: =, line: 10, column: 2","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":3},"token":"=","message":"invalid symbol, token: =, line: 10, column: 3","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":4},"token":"=","message":"invalid symbol, token: =, line: 10, column: 4","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":5},"token":"=","message":"invalid symbol, token: =, line: 10, column: 5","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":6},"token":"=","message":"invalid symbol, token: =, line: 10, column: 6","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":7},"token":"=","message":"invalid symbol, token: =, line: 10, column: 7","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":1},"token":">","message":"invalid symbol, token: >, line: 12, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":2},"token":">","message":"invalid symbol, token: >, line: 12, column: 2","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":3},"token":">","message":"invalid symbol, token: >, line: 12, column: 3","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":4},"token":">","message":"invalid symbol, token: >, line: 12, column: 4","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":5},"token":">","message":"invalid symbol, token: >, line: 12, column: 5","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":6},"token":">","message":"invalid symbol, token: >, line: 12, column: 6","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":7},"token":">","message":"invalid symbol, token: >, line: 12, column: 7","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid token","position":{"line":12,"column":9},"token":"ad586683a95c59b4e581081881037f614049040c","message":"invalid token, token: ad58668, line: 12, column: 9","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"structure","code":"unexpected token","position":{"line":13,"column":7},"token":""properties"","message":"unexpected token, token: "properties", line: 13, column: 7","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"structure","code":"unexpected end of file","position":{"line":1,"column":1},"token":"}","message":"unexpected end of file, token: }, line: 1, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":1},"token":"<","message":"invalid symbol, token: <, line: 8, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":2},"token":"<","message":"invalid symbol, token: <, line: 8, column: 2","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":3},"token":"<","message":"invalid symbol, token: <, line: 8, column: 3","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}) |
JSON_PARSE |
The file is not a valid JSON file. json: [stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":4},"token":"<","message":"invalid symbol, token: <, line: 8, column: 4","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}) |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
JSON_PARSING_ERROR |
Json parsing error: invalid symbol Url: stable/2023-04-01/examples/Certificates_CreateOrUpdate.json#L8:1 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
Can you please fix the swagger Lint diff warnings : https://github.com/Azure/azure-rest-api-specs/pull/29773/checks?check_run_id=27249014316 |
...source-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json
Outdated
Show resolved
Hide resolved
|
Also please update the descrption section and follow all the instructions on that carefully. This PR needs a base commit of the previous api version so that we can do a diff across the versions and compare. |
@raosuhas I apologize for the commit confusion. Please take a look at the version specific diff in this file here : d770711#diff-57df7de9e3f104a102d3a74c90fdbff079feaecc51359f260974956497d1beef This is already approved in private repo here: What we do is just copying and publishing the private api which is tested well. |
Errors introduced by this PR is resolved now |
|
@raosuhas while I don't have access to remove the |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
165255a to
add4ff9
Compare
|
Sorry for triggering extra things, rebase error. Now it's fixed. |
c083684 to
2d98f96
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@ms-bogdan-rotaru Would be great if we can revisit this PR and re-approve this as initial approval seems to be reverted due to rebase. Muchly appreciated! |
|
Hi, @zaowang-ms. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @zaowang-ms. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.